[Webkit-unassigned] [Bug 62802] [GTK] Fix typos in PageClientImpl::getEditorCommandsForKeyEvent()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 16 10:50:51 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62802





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-06-16 10:50:51 PST ---
(From update of attachment 97461)
View in context: https://bugs.webkit.org/attachment.cgi?id=97461&action=review

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:62
> +    ASSERT(event.type() == WebEvent::KeyDown || event.type() == WebEvent::KeyUp);
> +    KeyBindingTranslator::EventType type = event.type() == WebEvent::KeyDown ?
> +        KeyBindingTranslator::KeyDown : KeyBindingTranslator::KeyUp;
>      m_keyBindingTranslator.getEditorCommandsForKeyEvent(const_cast<GdkEventKey*>(&event.nativeEvent()->key), type, commandList);

The typo fix looks good, but a  WebEvent::KeyDown and a WebEvent.KeyPress event are two very different things.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list