[Webkit-unassigned] [Bug 60170] [Chromium] Speech-enabled input fields need the ability to trigger without a click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60170


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96120|review?                     |review-
               Flag|                            |




--- Comment #12 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-06-16 10:38:37 PST ---
(From update of attachment 96120)
View in context: https://bugs.webkit.org/attachment.cgi?id=96120&action=review

> Source/WebKit/chromium/public/WebInputElement.h:80
> +        WEBKIT_API bool isSpeechEnabled() const;

it looks like toggleSpeechRecognition and isSpeechEnabled are related methods, but
they do not use the same terms.  if isSpeechEnabled is supposed to return true
when toggleSpeechRecognition enabled the feature, then isSpeechEnabled should really
be named isSpeechRecognitionEnabled.  that way the names of the methods reinforces
the relationship without need for further documentation.

also, we don't have any other "toggle" APIs like this.  normally, we have
isFooEnabled and enableFoo(bool).  why not follow that pattern here?

> Tools/DumpRenderTree/LayoutTestController.h:112
> +    void toggleSpeechInput(JSContextRef inputElement);

same nit:  seems like this would be better as a boolean setter.  why does the
caller have to guess or know the state in order to decide if they should call
toggle or not?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.