[Webkit-unassigned] [Bug 62777] [EFL][WK2] Add RunLoopEfl and WorkQueueEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62777


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97412|review?                     |review-
               Flag|                            |




--- Comment #9 from Sam Weinig <sam at webkit.org>  2011-06-16 10:12:44 PST ---
(From update of attachment 97412)
View in context: https://bugs.webkit.org/attachment.cgi?id=97412&action=review

> Source/WebKit2/Platform/WorkQueue.h:222
> +        public:
> +            WorkItemEfl(PassOwnPtr<WorkItem> item, WorkQueue* queue) : m_item(item), m_queue(queue) { }
> +            ~WorkItemEfl() { }
> +    
> +            WorkItem* item() const { return m_item.get(); }
> +            WorkQueue* queue() const { return m_queue; }
> +    
> +        private:
> +            OwnPtr<WorkItem> m_item;
> +            WorkQueue* m_queue;
> +    };
> +    
> +    class FdWorkItem : public WorkItemEfl {
> +        public:
> +            FdWorkItem(int fd, PassOwnPtr<WorkItem> item, WorkQueue* queue)   
> +                : WorkItemEfl(item, queue), m_fd(fd) { }
> +            ~FdWorkItem() { }
> +            int fd() const { return m_fd; }
> +    
> +        private:
> +            int m_fd;
> +    };
> +    
> +    class TermWorkItem : public WorkItemEfl {
> +        public:
> +            TermWorkItem(int pid, PassOwnPtr<WorkItem> item, WorkQueue* queue)
> +                : WorkItemEfl(item, queue), m_pid(pid) { }
> +            ~TermWorkItem() { }
> +            int pid() const { return m_pid; }
> +    
> +        private:
> +            int m_pid;
> +    };

The public: and private: should not be indented.  We also traditionally put each line of the initialization syntax on its own line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.