[Webkit-unassigned] [Bug 62688] [EFL] Functions including Ewk_View_Private_Data should not an API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62688





--- Comment #10 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-16 08:04:27 PST ---
(In reply to comment #8)
> May be, ewk_view_single.c and ewk_view_tiled.c would need ewk_private.h.

I tested when I upload and it's fine for me.
And although those files required ewk_private.h,
those can't include ewk_private.h because ewk_private.h include c++ matter.

So, we need to find proper way if it required.
I think that we can make other bugs to control it when it required.

BTW, Can I know why those files use *.c ?
If we don't have any reasons, it looks be better to change *.cpp.
it's just my two cents.

(In reply to comment #9)
> (From update of attachment 97398 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97398&action=review
> 
> > Source/WebKit/efl/ChangeLog:5
> > +        [EFL] Functions including Ewk_View_Private_Data should not an API.
> 
> Functions needing Ewk_View_Private_Data as parameter are not part of public API
> 

Thanks, english is more difficult than code fore me. :)
I'll update like you mentioned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.