[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61915


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97399|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #37 from Leandro Pereira <leandro at profusion.mobi>  2011-06-16 07:28:12 PST ---
(From update of attachment 97399)
View in context: https://bugs.webkit.org/attachment.cgi?id=97399&action=review

LGTM, just some small nits.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:354
> +    if (sd->changed.size) {
> +        if (priv->pageClient)
> +            priv->pageClient->page()->drawingArea()->setSize(IntSize(w, h), IntSize());
> +        sd->view.w = w;
> +        sd->view.h = h;
> +    }
> +    sd->changed.size = EINA_FALSE;

You could move the attribution to sd->changed.size inside the if block. Same below.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.