[Webkit-unassigned] [Bug 62653] [V8][Chromium] Make StringCache in V8 bindings per-isolate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62653





--- Comment #14 from anton muhin <antonm at chromium.org>  2011-06-16 05:52:19 PST ---
(From update of attachment 97351)
View in context: https://bugs.webkit.org/attachment.cgi?id=97351&action=review

LGTM

You should probably remove enableStringImplCache and related stuff now, when cache is accessible from any thread.

> Source/WebCore/bindings/v8/V8Binding.h:57
> +        inline v8::Local<v8::String> v8ExternalString(StringImpl* stringImpl) 

I don't think you need inline here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.