[Webkit-unassigned] [Bug 60170] [Chromium] Speech-enabled input fields need the ability to trigger without a click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60170





--- Comment #10 from Satish Sampath <satish at chromium.org>  2011-06-16 04:09:39 PST ---
(From update of attachment 96120)
> InputFieldSpeechButtonElement::onToggle()

onToggle doesn't seem like the right name for this function. It doesn't toggle between 2 states but moves the state from idle to recording and recording to waiting states. I would suggest moving the code under each case statement to separate functions and add a new toggleSpeechInputState() function which actually moves between Idle and Recording states. I think you'd want a pending recognition session to be cancelled and a new one started if this toggleSpeechInputState() function was called when state == Recognizing.

> RenderTextControlSingleLine::toggleSpeechRecognition()

could use the same name as mentioned above - toggleSpeechInputState()

> WEBKIT_API bool isSpeechEnabled() const;

suggest changing to isSpeechInputEnabled - "speech" is not the same as "speechInput"

> WEBKIT_API void toggleSpeechRecognition();
> LayoutTestController::toggleSpeechInput

change to toggleSpeechInputState() as above

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.