[Webkit-unassigned] [Bug 62444] [EFL][WK2] Add BackingStoreEfl for WebKit2 EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62444





--- Comment #10 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-16 01:39:53 PST ---
(In reply to comment #9)
> (From update of attachment 97229 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97229&action=review
> 
> Informal r-.
> 
> > Source/WebKit2/UIProcess/efl/BackingStoreEfl.cpp:40
> > +void BackingStore::paint(cairo_t* context, const IntRect& rect)
> 
> Can't this be shared with other Cairo-using ports?
> 
> > Source/WebKit2/UIProcess/efl/BackingStoreEfl.cpp:48
> > +void BackingStore::incorporateUpdate(ShareableBitmap* bitmap, const UpdateInfo& updateInfo)
> 
> If the platform-independent part of this function is also similar to other Cairo-using ports, consider splitting this method into two, and doing something along the lines of:
> 
>    if (!m_backingStoreSurface)
>       platformCreateBackingStoreSurface();
> 
>    scroll(...); ...
> 
> I'd talk with WinCairo and GTK+ devs before attempting this, though.
> 
> > Source/WebKit2/UIProcess/efl/BackingStoreEfl.cpp:77
> > +void BackingStore::scroll(const IntRect& scrollRect, const IntSize& scrollOffset)
> 
> This method could also be shared with GTK+ or other Cairo-using ports: the only part here that depends on Evas is obtaining the dimentions of the view object, so perhaps a little refactoring would make this platform-independent?

I think it is not a little refactoring to make platform-independent.
Because, 
We use the cairo_surface directly from evas_object_image, 
but GTK+ uses the WebCore::GtkWidgetBackingStore and cairo operations are delegated to that class.
The functions in the BackingStoreEfl.cpp and BackingStoreGtk seem similar, but they have different implementation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.