[Webkit-unassigned] [Bug 62692] [CMAKE][WK2] include cmakeconfig.h in WebKit2/config.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62692





--- Comment #4 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-15 16:36:15 PST ---
(In reply to comment #3)
> (From update of attachment 97241 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97241&action=review
> 
> > Source/WebKit2/config.h:61
> > -#if defined(BUILDING_QT__) || defined(BUILDING_GTK__)
> > +#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) || defined(BUILDING_WITH_CMAKE)
> >  
> >  #define WTF_USE_JSC 1
> >  #define WTF_USE_V8 0
> 
> This one looks wrong to me. Isn't there any port that might want WTF_USE_V8? Wasn't the EFL port recently adding support to use V8 instead of JSC?

Right, it's not good, but I don't know that webkit2 supports v8 now.
But, I'll check once more to find better way.

BTW, WebKit/EFL doesn't support to use v8 yet. I am waiting Bug 61350 and need to clean up other local patches because it's too old. :(

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.