[Webkit-unassigned] [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56397





--- Comment #38 from Ojan Vafai <ojan at chromium.org>  2011-06-15 15:52:53 PST ---
(In reply to comment #34)
> (From update of attachment 97206 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97206&action=review
> > Source/WebKit/chromium/src/ChromeClientImpl.cpp:966
> > +    logMessage.append(" during page dismissal (beforeunload, pagehide or unload).");
> 
> As I commented earlier, we should identify the event from which the modal dialog was open (beforeunload, pagehide, or unload.

This doesn't seem worth complicating the WebKit code over. Web developers who encounter this can easily add the appropriate logging to figure this out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.