[Webkit-unassigned] [Bug 62653] [V8][Chromium] Make StringCache in V8 bindings per-isolate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62653





--- Comment #11 from anton muhin <antonm at chromium.org>  2011-06-15 09:54:55 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > May the whole logic of string caching be moved into V8BindingPerIsolateData?
> 
> What are the benefits of doing so?
> 
> From the code organization standpoint, there are other caches in V8 bindings (DOMStore, NPObjects, per-binding function templates) that will need similar data in V8BindingPerIsolateData. I do not think should all move into V8BindingPerIsolateData.
> 
> What we could do though, is to have a separate class encapsulating string caching logic (it would combine StringCache, lastV8String and lastStringImpl; V8BindingPerIsolate data would contain an instance of this class); and do the similar thing for the other caches (a class for per-binding function template encapsulating rawTemplateMap and templateMap &c). 
> 
> But I'd prefer this refactoring to be a separate patch.

The reason is simple: there are many parts which never were supposed to be public (roughly, nothing supposed to be public).  Now everything is.  And sooner or later someone will try to abuse this stuff.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.