[Webkit-unassigned] [Bug 62527] [EFL][WK2] Change string operation to makeString()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62527


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |INVALID




--- Comment #16 from Leandro Pereira <leandro at profusion.mobi>  2011-06-15 09:20:09 PST ---
(In reply to comment #15)
> This patch is wrong. makeString is deprecated, using String operator+ gives
> exactly the same performance. This has been changed recently. 
> 
> use "osVersion = name.sysname + " " + name.machine;"
> You are not required to cast to Strings first.
> 
> The StringAppend template solution will reduce this String concatting operation
> to just a single malloc of the final size, no appending is done at all.

You're right. I've rolled this out as r88944. Changing this bug status to 'invalid'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.