[Webkit-unassigned] [Bug 62730] New: Python checks for sys.platform have to be relaxed and/or extended for Linux >=3.0-rc1 support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62730

           Summary: Python checks for sys.platform have to be relaxed
                    and/or extended for Linux >=3.0-rc1 support
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gentoo at tk-webart.de


Hi,

while trying to build the chromium web browser on a system with Linux kernel 3.0-rc2 installed, I realized that python reports 'linux3' in sys.platform for Linux kernel version >=3.0-rc1.

That breaks several lookup dicts and conditional expressions in chromium's own code as well as in WebKit.

I will attach a patch shortly, which incorporates the following change to the relevant parts of WebKit.

  Add support for Linux kernels >=3.0-rc1 in Python related build files by:
    - replacing occurences of sys.platform == 'linux2' with
       sys.platform.startswith('linux')
    - congregating occurences of sys.platform in ('linux[X]', 'linuxY', ...)
       to sys.platform.startswith('linux')
    - adding the key 'linux3' to all relevant lookup dicts

Unfortunately I can't check, whether my changes would enable Linux-3-compatibility for other WebKit-based browsers, too. So, perhaps, someone with more insight to WebKit could check the rest of the code for occurrences of, e.g., "sys.platform == 'linux2'" and see, if it breaks something, if they are changed to "sys.platform.startswith('linux')".

If there's something wrong with the formatting of my patch, or otherwise, please let me know. It's my first contribution to WebKit.

For reference:
http://code.google.com/p/chromium/issues/detail?id=85845
http://bugs.gentoo.org/show_bug.cgi?id=371245

Best regards,
Torsten

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.