[Webkit-unassigned] [Bug 62642] [Efl] Add EflOwnPtr to wtf

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62642


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97131|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #15 from Martin Robinson <mrobinson at webkit.org>  2011-06-15 07:54:02 PST ---
(From update of attachment 97131)
View in context: https://bugs.webkit.org/attachment.cgi?id=97131&action=review

> Source/JavaScriptCore/wtf/efl/EflOwnPtr.cpp:32
> +{
> +    evas_object_del(ptr);
> +}

Are Evas Objects always reference counted [1]? If so it would probably be more correct to specialize RefPtr instead.

1. http://docs.enlightenment.org/auto/evas/group__Evas__Object__Group__Basic.html#gaa22895e88e2cb157b9c38a6d3ce10723

>> Source/JavaScriptCore/wtf/efl/EflOwnPtr.h:132
>> +}
> 
> I think we just need this type specialization for OwnPtr and then OwnPtr will work like a charm for what you want.

Totally agree with Eric here. Just be sure to always use new when allocating memory with OwnPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.