[Webkit-unassigned] [Bug 62680] markup-dump conversion + rename: editing/deleting/5408255.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 15 00:37:00 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62680





--- Comment #13 from Wyatt Carss <wcarss at chromium.org>  2011-06-15 00:37:00 PST ---
(In reply to comment #12)
> (In reply to comment #7)
> > I tried svn revert'ing my directory and applying the earlier patch (with the move), and it failed, so I redid the change without the rename. After this lands, I'll update and submit a new patch -- possibly with multiple renames, as I plan to convert multiple bugs known only by their radr number.
> 
> That's because you probably had old .html files.  You should use Tools/Scripts/webkit-patch apply-attachment.

I did use that script, from a clean svn - but something messed up when applying the rename portion.

Anyway, I'm confused about what you suggested. As I understand this, the markup is most worth seeing if something is wrong. If the delete button still exists, it will be shown in the markup dump. If the test passes, the markup dump is kind of confusing, because it's just two newlines. So in the case that the test passes, I set the markup to be the word "Success" so that it's clear that this is the preferred case.

If the test fails, the markup is dumped without modification while the description remains above, identifying that only the word "Success" should have appeared.

I could conceivably dump the whole page markup instead of just what's inside the content-editable div. Then there would be meaningful output in both the pass and the fail case. I didn't want to insert another <div></div> unless it was necessary, in case it messed with the test. I think it would be needed to put something like "FAIL" in while preserving the content-editable div's innerHTML. Advice welcome on that!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list