[Webkit-unassigned] [Bug 62444] [EFL][WK2] Add BackingStoreEfl for WebKit2 EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62444





--- Comment #7 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-14 22:04:38 PST ---
(In reply to comment #5)
> (From update of attachment 96718 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96718&action=review
> 
> There is a lot of Cairo functionality here that is improperly limited to EFL.  Can this patch be combined with some of our GTK/WinCairo stuff for better reuse?
> 
I think that EFL's BackingStore and GTK's one can be combined if the EFL's BackingStore can use GtkWidgetBackingStoreCairo.
In order to do that, we have to change the GtkWidgetBackingStore to common one firstly.
I will investigate GtkWidgetBackingStore and try to make patch for that. 

> > Source/WebKit2/UIProcess/BackingStore.h:44
> > +#if PLATFORM(GTK) || PLATFORM(EFL)
> 
> This needs to be based on the Cairo feature, not GTK/EFL.  A patch to this effect was already submitted IIRC by mrobinson, but I'm not sure the state.
> 

Done. I've change that to USE(CAIRO)

> > Source/WebKit2/UIProcess/BackingStore.h:76
> > +#elif PLATFORM(GTK) || PLATFORM(EFL)
> 
> Ditto:  This is PLATFORM(CAIRO) (or is it FEATURE(CAIRO) now?)

Done. Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.