[Webkit-unassigned] [Bug 62688] [EFL] Functions including Ewk_View_Private_Data should not an API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62688





--- Comment #4 from Lucas De Marchi <demarchi at webkit.org>  2011-06-14 20:31:40 PST ---
(In reply to comment #0)
> WebKit/EFL have many APIs, but some of them looks not useless.
> 
> First, functions including Ewk_View_Private_Data should be private or change it to Evas_Object.
> 
> ewk_view_repaints_get(Ewk_View_Private_Data*, ...)
> ewk_view_scroll_requests_get(Ewk_View_Private_Data*, ...)
> ewk_view_repaint_add(Ewk_View_Private_Data*, ...)
> ewk_view_layout_if_needed_recursive(Ewk_View_Private_Data*, ...)
> ewk_view_scrolls_process(Ewk_View_Private_Data*, ...)
> 
> I checked old eve(I'll check latest in my home) and our browser, but those are only used internally.
> Does it required?
> 
> My first suggestion is moving them to ewk_private.h
> If not, how do you think about change it to Evas_Object?

Thinking again... I think not all of them are used by a subclass implementation and the others we could indeed change to use Evas_Object as argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.