[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61915





--- Comment #33 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-14 18:36:58 PST ---
(In reply to comment #31)
> (From update of attachment 97100 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97100&action=review
> 
> Looks almost OK -- just a couple of questions.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:348
> > +    if (priv->pageClient && sd->changed.size && ((w != sd->view.w) || (h != sd->view.h))) {
> 
> Couldn't you just use sd->changed.size here?
> 

I've modified that code as follows:
-    if (priv->pageClient && sd->changed.size && ((w != sd->view.w) || (h != sd->view.h))) {
-        priv->pageClient->page()->drawingArea()->setSize(IntSize(w, h), IntSize());
+    if (sd->changed.size && ((w != sd->view.w) || (h != sd->view.h))) {
+        if (priv->pageClient)
+            priv->pageClient->page()->drawingArea()->setSize(IntSize(w, h), IntSize());

I've just move priv->pageClient.


> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:355
> > +    if (sd->changed.position && ((x != sd->view.x) || (y != sd->view.y))) {
> 
> Ditto, for sd->changed.position.

I don't know what can I do more.
Actually, I could not catch your point.
Would you explain more about what you want?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.