[Webkit-unassigned] [Bug 62628] [EFL] Crash when running EWebLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62628


Ryuan Choi <ryuan.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ryuan.choi at samsung.com




--- Comment #19 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-14 17:50:10 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> 
> Anyway, the patch might not be right but this piece of code does look wrong. It's not possible that m_parser becomes 0 after calling m_parser->flush(this) and the check should be removed or moved up like the patch Michal sent.

Although it looks wrong, I think that it can be possible if m_parser->flush make recursion.

I tested my assumption like below.
@@ -220,11 +221,14 @@ void DocumentWriter::endIfNotLoadingMainResource()
     RefPtr<Frame> protector(m_frame);

     // FIXME: m_parser->finish() should imply m_parser->flush().
+    static int counter = 0;
+    printf (" counter %d entered\n", ++counter);
     m_parser->flush(this);
+    printf (" counter %d leaved\n", counter--);
     if (!m_parser)
         return;
     m_parser->finish();
     m_parser = 0;
 }

# ./WebKitBuild/Release/Programs/EWebLauncher file:///workspace/webkits/efl-webkit/LayoutTests/fast/parser/iframe-sets-parent-to-javascript-url.html
 counter 1 entered
 counter 1 leaved
 counter 1 entered
 counter 2 entered
 counter 2 leaved
 counter 1 leaved
 counter 1 entered
factor=1.000000, intFactor=100, zoomLevels[5]=100, zoomLevels[6]=110
 counter 2 entered
 counter 2 leaved
 counter 1 leaved

Michal,
This issue is because FrameLoaderClientEfl doesn't implement makeRepresentation or revertToProvisionalState.
WebKit/EFL should check it and clear parser in finishedLoading like other ports.

However, I am studying why used setEncoding for it. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.