[Webkit-unassigned] [Bug 62680] markup-dump conversion + rename: editing/deleting/5408255.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62680


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97202|review?                     |review-
               Flag|                            |




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-06-14 17:49:43 PST ---
(From update of attachment 97202)
View in context: https://bugs.webkit.org/attachment.cgi?id=97202&action=review

> LayoutTests/ChangeLog:8
> +        editing/deleting/5408255.html is now editing/deleting/delete-button-failure.html

delete-button-failure sounds too general.  Since this test is concerned with -webkit-user-select: none, I'd include that in the name.  Something like delete-button-with-select-none.

> LayoutTests/editing/deleting/delete-button-failure.html:26
> +    if(!deleteButton && !listElement)
> +        document.getElementById("test").innerHTML = "Success";

I don't think not having list item necessarily makes this test pass because it could be leaving other elements such as ul or text. r- because of this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.