[Webkit-unassigned] [Bug 62621] Span ID duplicated when pressing enter at beginning of span

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62621





--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2011-06-14 17:18:28 PST ---
(From update of attachment 97197)
View in context: https://bugs.webkit.org/attachment.cgi?id=97197&action=review

> LayoutTests/editing/inserting/return-key-span-start-expected.txt:7
> +| <span>
> +|   id="dupe"
> +|   <div>
> +|     <span>
> +|       <br>

Wow!  Why are we nesting div inside span?  Can we fix this?

> Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:140
> +        // It should always be okay to delete the id of cloned elements, because the codepaths that call this method
> +        // only call appendBlockPlaceholder and setEndingSelection afterward, which never delete the original node.

I'm sad that there's no way to assert this.  Also this comment might be too verbose.  What matters is the fact we don't delete the cloned elements or the original elements, not the fact we call appendBlockPlaceholder and setEndingSelection.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.