[Webkit-unassigned] [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 17:12:32 PDT 2011


--- Comment #26 from Sreeram Ramachandran <sreeram at chromium.org>  2011-06-14 17:12:31 PST ---
(From update of attachment 97187)
View in context: https://bugs.webkit.org/attachment.cgi?id=97187&action=review

>>>> Source/WebKit/chromium/src/ChromeClientImpl.cpp:959
>>>> +    logMessage += " during page dismissal (beforeunload, pagehide or unload).";
>>> Can't we identify which one it is?
>> Sure, if you are okay with instrumenting stuff in WebCore/loader/FrameLoader.cpp. Instead of that, it might be better (but more hacky) to pass along the JS source file and line number here.
> Oh, that's not what I meant.  Can we say whether it was beforeunload, pagehide, or unload?

Yeah, I understood you. To differentiate between those, we need to add some hooks in FrameLoader.cpp. Say by changing m_pageDismissalEventBeingDispatched from a bool to an enum or such. As an alternative, instead of saying which type of unload handler it was, we might as well just emit the JS source details (file and line number), though I think passing along that information to this spot will be much hackier.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list