[Webkit-unassigned] [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56397





--- Comment #24 from Sreeram Ramachandran <sreeram at chromium.org>  2011-06-14 17:05:59 PST ---
(From update of attachment 97187)
View in context: https://bugs.webkit.org/attachment.cgi?id=97187&action=review

>> Source/WebCore/page/Chrome.cpp:210
>> +}
> 
> I don't see any point in adding this inline function.  It needlessly adds new indirection.  We can just call frame->loader()->pageDismissalEventBeingDispatched() directly.

Done.

>> Source/WebKit/chromium/src/ChromeClientImpl.cpp:942
>> +    String logMessage = "Blocked ";
> 
> StringBuilder plz.

Done.

>> Source/WebKit/chromium/src/ChromeClientImpl.cpp:959
>> +    logMessage += " during page dismissal (beforeunload, pagehide or unload).";
> 
> Can't we identify which one it is?

Sure, if you are okay with instrumenting stuff in WebCore/loader/FrameLoader.cpp. Instead of that, it might be better (but more hacky) to pass along the JS source file and line number here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.