[Webkit-unassigned] [Bug 62621] Span ID duplicated when pressing enter at beginning of span

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 16:49:40 PDT 2011


--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2011-06-14 16:49:40 PST ---
(In reply to comment #6)
> > More interesting question to ask is whether if we'd ever delete the original element after cloning hierarchy, in which case we shouldn't be removing id attribute.
> This function is called from two places in InsertParagraphCommand, and they both look like this:
>         appendBlockPlaceholder(cloneHierarchyUnderNewBlock(ancestors, blockToInsert));
>         // In this case, we need to set the new ending selection.
>         setEndingSelection(VisibleSelection(insertionPosition, DOWNSTREAM));
>         return;
> Neither appendBlockPlaceholder nor setEndingSelection ever delete any nodes, so I think we're safe here.

Right, and that'll be a useful comment to have.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list