[Webkit-unassigned] [Bug 62621] Span ID duplicated when pressing enter at beginning of span

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62621





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2011-06-14 16:42:37 PST ---
(From update of attachment 97191)
View in context: https://bugs.webkit.org/attachment.cgi?id=97191&action=review

> Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:139
> +        // Delete id attribute from the cloned child element because the same id cannot be used for more than one element

I don't think this comment is necessary.  It's self-evident.
More interesting question to ask is whether if we'd ever delete the original element after cloning hierarchy, in which case we shouldn't be removing id attribute.

> Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:141
> +        child->removeAttribute(HTMLNames::idAttr, ec);

Do you really need "HTMLNames::"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.