[Webkit-unassigned] [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 16:33:53 PDT 2011


--- Comment #22 from Ryosuke Niwa <rniwa at webkit.org>  2011-06-14 16:33:52 PST ---
(From update of attachment 97187)
View in context: https://bugs.webkit.org/attachment.cgi?id=97187&action=review

> Source/WebCore/page/Chrome.cpp:210
> +static inline bool isDuringPageDismissal(const Frame* frame)
> +{
> +    return frame->loader()->pageDismissalEventBeingDispatched();
> +}

I don't see any point in adding this inline function.  It needlessly adds new indirection.  We can just call frame->loader()->pageDismissalEventBeingDispatched() directly.

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:959
> +    logMessage += " during page dismissal (beforeunload, pagehide or unload).";

Can't we identify which one it is?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list