[Webkit-unassigned] [Bug 58191] Use console.log() instead of alert() in unload handlers in tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 13:37:33 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58191





--- Comment #26 from Ryosuke Niwa <rniwa at webkit.org>  2011-06-14 13:37:32 PST ---
(In reply to comment #24)
> I think modifying these tests is not a big deal. In the two months since I uploaded the first patch, no new instances of alert() in unload handlers (beforeunload, unload, pagehide) have been introduced. Besides, unless we make the console message exactly the same as the alert ("ALERT: message"), test expectations will still have to be modified.

Expectations change will be much less controversial than test change because you can just land port-specific results.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list