[Webkit-unassigned] [Bug 56393] Without checking existence of the renderer of the element, tries to access the enclosing layer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56393





--- Comment #22 from Alexis Menard <alexis.menard at openbossa.org>  2011-06-14 11:01:42 PST ---
(In reply to comment #21)
> (In reply to comment #20)
> 
> The "this" pointer is null on all platforms (at least the ones I looked at).
> It only reset's on Symbian because of a difference in execution environment.
> 
> The renderer is null causing a null "this".  This is show in the small test case by an iframe with style=display:none to an html page containing a .swf
> plugin.
> 
> I will look again in the debugger and see if I can exactly where and why the
> renderer is set to null.

But the test should be done before the function call, i.e. before enclosingLayer() is called like the other part of your patch does.

ASSERT is not run in release so what's the purpose of the ASSERT, to check you don't enter in enclosingLayer() with an invalid pointer. It's not the right way, you should ASSERT *before* the call.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.