[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61915


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97100|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #31 from Leandro Pereira <leandro at profusion.mobi>  2011-06-14 08:57:28 PST ---
(From update of attachment 97100)
View in context: https://bugs.webkit.org/attachment.cgi?id=97100&action=review

Looks almost OK -- just a couple of questions.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:348
> +    if (priv->pageClient && sd->changed.size && ((w != sd->view.w) || (h != sd->view.h))) {

Couldn't you just use sd->changed.size here?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:355
> +    if (sd->changed.position && ((x != sd->view.x) || (y != sd->view.y))) {

Ditto, for sd->changed.position.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.