[Webkit-unassigned] [Bug 62634] [GTK] Add a statusbar to MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62634


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97118|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-06-14 08:26:38 PST ---
(From update of attachment 97118)
View in context: https://bugs.webkit.org/attachment.cgi?id=97118&action=review

Looks good, but please make the following changes before landing.

> Tools/MiniBrowser/gtk/BrowserWindow.c:47
>      GtkWidget* mainBox;
>      GtkWidget* uriEntry;
> +    GtkWidget *statusBar;
>      WKViewRef webView;
>  
> +    guint statusBarContextId;
> +
>      gchar* title;
>      gdouble loadProgress;

Do you mind cleaning up the rest of this section as well since you're touching it?

> Tools/MiniBrowser/gtk/WebBundle/WebBundleMain.c:35
> +static void mouseDidMoveOverElement(WKBundlePageRef page, WKBundleHitTestResultRef hitTestResult, WKEventModifiers modifiers, WKTypeRef* userData, const void *clientInfo)

The asterisk on WKTypeRef should be on userData.

> Tools/MiniBrowser/gtk/main.c:32
> +WKContextRef processContext;

This could be local and passed as an argument to addInjectedBundleToContext.

> Tools/MiniBrowser/gtk/main.c:35
> +static void initContext()

I'd prefer this to be called something like addInjectedBundleToContext.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.