[Webkit-unassigned] [Bug 61993] [EFL][WK2] add WebKit2 EFL port's NativeWebMouseEvent, NativeWebWheelEvent and NativeWebKeyboardEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61993





--- Comment #14 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-14 06:31:00 PST ---
(In reply to comment #12)
> (From update of attachment 96732 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96732&action=review
> 
> > Source/WebKit2/ChangeLog:7
> > +
> 
> Missing summary for Patch

Done.

> 
> > Source/WebKit2/Shared/efl/WebEventFactory.cpp:60
> > +    if (button == 1)
> 
> I think it is better to use constant instead of "1"
> 
> > Source/WebKit2/Shared/efl/WebEventFactory.cpp:62
> > +    if (button == 2)
> 
> ditto.

Done. I added enum for that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.