[Webkit-unassigned] [Bug 62451] [EFL] open keyIdentifierForEvasKeyName and windowsKeyCodeForEvasKeyName to use in the WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 06:02:27 PDT 2011


--- Comment #5 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-14 06:02:26 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 96738 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=96738&action=review
> > > 
> > > > Source/WebCore/platform/PlatformKeyboardEvent.h:214
> > > > +
> > > > +        // Used by WebKit2
> > > > +        static String keyIdentifierForEvasKeyName(String&);
> > > > +        static int windowsKeyCodeForEvasKeyName(String&);
> > > 
> > > Do we really need this? What if WebKit2 is not used? I know GTK is using a similar approach to this, but maybe there's a better approach?
> > 
> > Yes, I really need this because we have to copy all codes for KeyMap (createKeyMap(), createWindowKeyMap()) to the WebKit2 efl port without this.
> > And I think that this code will not raise any problem without WebKit2.
> > About a better approach,
> > I think it is better to unite WebKit1's PlatformKeyboardEvent and WebKit2's NativeWebKeyboardEvent but it is hard to me because that will cause modifications of all ports's KeyboardEvent.
> > I will be grateful if you share your idea about that :)
> I certainly think it's better to share code among all ports, even if it's more difficult to do. However I don't know this piece of code sufficiently to tell you what to do. I'm CC'ing people who know more than me on this area.

The WebCore/platform/PlatformKeyboardEvent and WebKit2/Shared/WebKeyboardEvent looks very similar. but WebKeyboardEvent has the encode and decode function to transmit to the WebProcess.
I think it is hard to unify those two classes.
So, I have another idea about that
=> adding the function which creats WebKeyboardEvent from PlatformKeyboardEvent.
If that exists, I can create PlatformKeyboardEvent firstly (using PlatformKeyboardEventEfl) and then convert it to the WebKeyboardEvent.
in this case, we do not have to open PlatformKeyboardEvent's static functions for KeyMap.
How do you think?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list