[Webkit-unassigned] [Bug 53359] Web Inspector: Allow the console to persist on page refresh or navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53359


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96666|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from Pavel Feldman <pfeldman at chromium.org>  2011-06-14 05:48:12 PST ---
(From update of attachment 96666)
View in context: https://bugs.webkit.org/attachment.cgi?id=96666&action=review

A couple of nits, otherwise looks good.

> Source/WebCore/ChangeLog:13
> +        No new tests. (OOPS!)

I think it is possible to test this. Check out LayoutTests/inspector/console/console-log-toString-object.html on how to reload a page and dump console messages afterwards. function test() is executed within inspector context, so you should be able to set your preserve flag there prior to calling the reload.

> Source/WebCore/inspector/front-end/ConsoleView.js:465
> +        contextMenu.appendCheckboxItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Preserve log" : "Preserve Log"), preserveLogItemAction, WebInspector.settings.preserveConsoleLog);

This string should be added to the WebCore/English.lproj/localizedStrings.js

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.