[Webkit-unassigned] [Bug 45274] Breaking Float: floated block level element following inline element in floated container breaks to next line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45274





--- Comment #33 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2011-06-14 02:53:45 PST ---
(In reply to comment #32)
> (From update of attachment 94349 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=94349&action=review
> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1677
> > +    float m_additionalWidth;
> 
> What does "additional" width mean here?  It should be widths of something, right?  What are they?  I can't tell whether this patch is correct or not but adding this member variable scares me to no end because I can't tell what it is.

Actually, "additional" means "extra".
As you know, if there are 2 more spaces between elements, there are ignored except one. The width of float element which has white space at next includes a width of this "one" white space. So the width of float is bigger than actual one.
(This is why fitsOnLine failed.)

m_additionalWidth saves the width of an white space, and is used to subtract later when float is checked whether it fits on line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.