[Webkit-unassigned] [Bug 62620] dump-as-text conversion: editing/deleting/5300379.html

Mon Jun 13 21:14:49 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=62620

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97064|review?                     |review-
               Flag|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-06-13 21:14:49 PST ---
(From update of attachment 97064)
View in context: https://bugs.webkit.org/attachment.cgi?id=97064&action=review

> LayoutTests/editing/deleting/5300379.html:4
> +<div class="description">Sets cursor to 0 in the container above and deletes by word backward, checking for a hang, then inserts 2 words and repeats, to ensure that backward word deletion isn't a no-op.</div>

I'm afraid that adding extra div will cause this hang not to reproduce.  I'd prefer printing this using InsertText as done in the case !window.layoutTestController.

Also, this description is kind of convoluted.  It doesn't really tell us what we're trying to test.  We should at least say that "you should see 'Success' below" because that's the minimum requirement for this test to pass.  Also, setting cursor (note, it's caret/insertion point; cursor usually refers to a mark that indicates the current position of your pointing device) to offset 0 isn't really useful information because the div was empty to begin with.  What's significant is the fact we're deleting word backward in an empty editable div, and we're then making sure deleting word backward will remove exactly one word.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.