[Webkit-unassigned] [Bug 62613] No context for javascript parse errors.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 13 18:49:59 PDT 2011


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
  Attachment #97047|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #2 from Oliver Hunt <oliver at apple.com>  2011-06-13 18:49:59 PST ---
(From update of attachment 97047)
View in context: https://bugs.webkit.org/attachment.cgi?id=97047&action=review

The logic for this patch looks fine, however you need to have a slightly more detailed changelog (basically saying what the change you're making is).

Normally you'd be expected to have a new testcase for this, but i suspect if you do run-webkit-tests you'll see a large number of failures due to the changed output.  Depending on what the changes are we may consider the new test outputs to be sufficient on their own, otherwise you'll need to write a new test specifically.

r- due to the test problem.

> Source/JavaScriptCore/ChangeLog:7
> +

You should have a more detailed description here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list