[Webkit-unassigned] [Bug 62430] <progress> should support :indeterminate pseudo-class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62430


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96951|review?                     |review+
               Flag|                            |




--- Comment #15 from Kent Tamura <tkent at chromium.org>  2011-06-13 16:11:59 PST ---
(From update of attachment 96951)
View in context: https://bugs.webkit.org/attachment.cgi?id=96951&action=review

> Source/WebCore/html/HTMLProgressElement.cpp:151
> +        if ((wasIndeterminate && isDeterminate()) || (!wasIndeterminate && !isDeterminate()))

We can write this as
  if (wasIndeterminate == isDeterminate())
Also, I think wasIndeterminate should be changed to wasDeterminate.
  bool wasDeterminate = render->isDeterminate();
  render->updateFromEelemnt();
  if (wasDetermiante != isDeterminate)
      setNeedsStyleRecalc();

"if (status is change) setNeedsStyleRecalc()" is a common idiom and easy to read for us.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.