[Webkit-unassigned] [Bug 62536] [EFL] Supports to execute "redo" command.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62536





--- Comment #6 from Jaehun Lim <ljaehun.lim at samsung.com>  2011-06-13 16:03:13 PST ---
(In reply to comment #2)
> The code looks like the one in the GTK+ port but without some additional checks (for m_isInRedo, for example). I suggest porting those checks as well.
> 
> > Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:150
> > +    redoStack.clear();
> 
> Perhaps it might be good to check if you're not inside a redo operation?
> 
> > Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:194
> > +    RefPtr<WebCore::EditCommand> command(*(--redoStack.end()));
> 
> What if the stack is empty? You should probably enclose this block of code inside an if (canRedo())

I missed some checking codes as you said.
I'll make another patch soon. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.