[Webkit-unassigned] [Bug 62593] Optimization: do a single fillRect when painting the background in RenderBoxModelObject::paintFillLayerExtended

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62593


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96999|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-06-13 13:39:23 PST ---
(From update of attachment 96999)
View in context: https://bugs.webkit.org/attachment.cgi?id=96999&action=review

There is no need here to make any of the calls to isValid. Any color that is not valid will also have an alpha of zero. Instead all the code can just check for non-zero alpha values.

We’d like to eliminate the concept of “valid” entirely from Color, so it’s best not to add more checks for validity.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:748
> +            baseColor = view()->frameView()->baseBackgroundColor();
> +            if (baseColor.alpha() == 0)
> +                baseColor.setRGB(0, 0, 0);

Will this do the same thing as the old code if the base color has an alpha of 50%? I don’t think it will.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.