[Webkit-unassigned] [Bug 62345] [V8][Chromium] Use per-isolate embedder data instead of statics for caches in bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62345


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96803|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #11 from Adam Barth <abarth at webkit.org>  2011-06-13 13:15:21 PST ---
(From update of attachment 96803)
View in context: https://bugs.webkit.org/attachment.cgi?id=96803&action=review

I'm not in love with the raw memory management, but I don't see any other choice.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2206
> +    if (result != data->rawTemplateMap().end())  return result->second;

One statement per line, plz.

> Source/WebCore/bindings/v8/V8Binding.cpp:79
> +    void* data = isolate->GetData();
> +    if (data)
> +        delete static_cast<V8BindingPerIsolateData*>(data);

This code is still ugly, but I guess that's what we get for using void* in the V8 API.  This branch is probably not needed.  delete 0 is supposed to be safe.

> Source/WebCore/bindings/v8/V8Utilities.h:73
> +        v8::Persistent<v8::Context> m_context;

Please use OwnHandle.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.