[Webkit-unassigned] [Bug 54752] [EFL] Soup authentication feature implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54752





--- Comment #18 from Leandro Pereira <leandro at profusion.mobi>  2011-06-13 12:13:34 PST ---
(From update of attachment 96085)
View in context: https://bugs.webkit.org/attachment.cgi?id=96085&action=review

Regarding the function to set the callback, that's exactly what I said about not having a way around it. This seems to be a special case, so I think it is fine leaving as is.

> Source/WebKit/efl/ewk/ewk_auth_soup.cpp:102
> +    auth_data = (Ewk_Auth_Data*)calloc(1, sizeof(Ewk_Auth_Data));
> +    auth_data->msg = msg;
> +    auth_data->auth = auth;
> +    auth_data->session = session;

Just make sure that, if calloc() fails, you return from this function before writing to it (and before pausing/incrementing references).

> Source/WebKit/efl/ewk/ewk_auth_soup.h:37
> +#define EWK_TYPE_SOUP_AUTH_DIALOG            (ewk_auth_soup_dialog_get_type ())
> +#define EWK_SOUP_AUTH_DIALOG(object)         (G_TYPE_CHECK_INSTANCE_CAST ((object), EWK_TYPE_SOUP_AUTH_DIALOG, Ewk_Soup_Auth_Dialog))
> +#define EWK_SOUP_AUTH_DIALOG_CLASS(klass)    (G_TYPE_CHECK_CLASS_CAST ((klass), EWK_TYPE_SOUP_AUTH_DIALOG, Ewk_Soup_Auth_Dialog))
> +#define EWK_IS_SOUP_AUTH_DIALOG(object)      (G_TYPE_CHECK_INSTANCE_TYPE ((object), EWK_TYPE_SOUP_AUTH_DIALOG))
> +#define EWK_IS_SOUP_AUTH_DIALOG_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), EWK_TYPE_SOUP_AUTH_DIALOG))
> +#define EWK_SOUP_AUTH_DIALOG_GET_CLASS(obj)  (G_TYPE_INSTANCE_GET_CLASS ((obj), EWK_TYPE_SOUP_AUTH_DIALOG, Ewk_Soup_Auth_Dialog))

Pay attention to spaces before parenthesis.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.