[Webkit-unassigned] [Bug 51941] refactor HTMLLinkElement to allow Link header implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51941





--- Comment #39 from Gavin Peters <gavinp at chromium.org>  2011-06-13 10:08:46 PST ---
(From update of attachment 78699)
View in context: https://bugs.webkit.org/attachment.cgi?id=78699&action=review

>> Source/WebCore/loader/LinkLoaderClient.h:44
>> +    virtual ~LinkLoaderClient();
> 
> Do we need this?  No one should be deleting subclasses via this pointer, right?

Sure, but I tried without it, and the Mac build elevated the no-virtual-destructor warning to an error.  See my latest upload: do you have any advice?

>> Source/WebCore/loader/LinkLoaderClient.h:47
>> +    virtual void linkError();
> 
> It seems like these should be pure virtual.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.