[Webkit-unassigned] [Bug 50173] corrupted pointer in webkit_web_view_get_resource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50173


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96960|                            |review-
               Flag|                            |




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-06-13 09:56:03 PST ---
(From update of attachment 96960)
View in context: https://bugs.webkit.org/attachment.cgi?id=96960&action=review

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4837
> +    g_object_ref(webView);

Please leave a comment here explaining that we want to keep the WebKitWebView alive until we have finished loading the main resource. You should also mention that the same approach is taken in the Mac port.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4855
>          priv->mainResource = 0;
>      } else
>        g_hash_table_remove(priv->subResources.get(), identifier);
> +
> +    g_object_unref(webView);

Here you should only unref the WebView if the main resource is done loading.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.