[Webkit-unassigned] [Bug 56935] [Qt] Implement accelerated compositing on WK2 Qt port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56935





--- Comment #13 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-06-13 07:33:20 PST ---
(From update of attachment 96896)
View in context: https://bugs.webkit.org/attachment.cgi?id=96896&action=review

> Source/WebKit2/Shared/WebLayerTreeInfo.cpp:36
> +    encoder->encode(CoreIPC::In(id, name, parent, children, flags, replica, mask));
> +    encoder->encode(CoreIPC::In(pos, size, transform, opacity, anchorPoint, childrenTransform, contentsRect));

Any reason why these are encoded separately?

> Source/WebKit2/Shared/WebLayerTreeInfo.h:58
> +    FloatPoint pos;

Dont we normally use location() in WebCore ?

> Source/WebKit2/Shared/WebLayerTreeInfo.h:64
> +    FloatSize size;
> +    TransformationMatrix transform;
> +    TransformationMatrix childrenTransform;
> +    IntRect contentsRect;
> +    float opacity;

how is size different from contentsRect.size() ?

> Source/WebKit2/Shared/WebLayerTreeInfo.h:86
> +    Vector<WebLayerInfo> layers;
> +    Vector<WebLayerID> deletedLayers;

Both are called layers, though one is a vector of layer ids and the one of of layer infos. A bit confusing

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.