[Webkit-unassigned] [Bug 62536] [EFL] Supports to execute "redo" command.

Mon Jun 13 06:44:25 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=62536

Raphael Kubo da Costa <kubo at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kubo at profusion.mobi

--- Comment #2 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-06-13 06:44:25 PST ---
The code looks like the one in the GTK+ port but without some additional checks (for m_isInRedo, for example). I suggest porting those checks as well.

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:150
> +    redoStack.clear();

Perhaps it might be good to check if you're not inside a redo operation?

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:194
> +    RefPtr<WebCore::EditCommand> command(*(--redoStack.end()));

What if the stack is empty? You should probably enclose this block of code inside an if (canRedo())

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.