[Webkit-unassigned] [Bug 62422] TiledBackingStore endlessly creates and destroys tiles due to an off-by-one error.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62422





--- Comment #10 from Yael <yael.aharon at nokia.com>  2011-06-13 05:38:02 PST ---
(From update of attachment 96932)
View in context: https://bugs.webkit.org/attachment.cgi?id=96932&action=review

I am not a reviewer, bellow are some comments.

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:200
> +IntPoint TiledBackingStore::preciseBottomRight(const IntRect& rect)
> +{

No need to make this a member, it should be a static function.

> Source/WebKit2/ChangeLog:11
> +        REGRESSION(r77928): Cause off-by-one error.

The off-by-one error was introduced in r78783 and r78785.

> Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp:337
> +IntPoint TiledDrawingAreaTile::preciseBottomRight(const IntRect& rect)
> +{

Same here. No need to make this a member, it should be a static function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.