[Webkit-unassigned] [Bug 61272] [Chromium] On-the-spot IME support for windowless plug-ins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61272


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95899|0                           |1
        is obsolete|                            |
  Attachment #95899|review?                     |
               Flag|                            |
  Attachment #96943|                            |review?
               Flag|                            |




--- Comment #12 from Hironori Bono <hbono at chromium.org>  2011-06-13 04:33:06 PST ---
Created an attachment (id=96943)
 --> (https://bugs.webkit.org/attachment.cgi?id=96943&action=review)
Patch v3

Greetings Tony and Tamura-san,

Thank you for your reviews and comments.

> Sorry, I misread your StringBuilder as StringBuffer. Using StringBuilder makes sense.

I have updated my change to use StringBuilder.

(In reply to comment #11)
> do these become WebInputEvents that would never be passed to WebWidget::handleInputEvent?

Right. This is only used for plug-ins.

> i'm concerned about defining plugin-specific input events.  can you tell me more about
> why these are input events for plugins and not input events for WebWidgets?  why wouldn't
> we just add methods for setting and confirming composition on WebPlugin?

Thank you for your comment. I have also considered this option before I started implementing this change. In brief, I have added an input event just because an IME event was mostly coupled with a keyboard events and it looked safer to use the same framework that sends keyboard events to send IME events. I'm not sure which is the better option in terms of sharing code between Chromium and Safari, adding an input event or adding a method to WebPlugin. Unfortunately, my Safari change for this issue is still in progress. (Even though this change is currently a Chromium-specific change, I would like to share code with Safari Win as much as possible.)

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.