[Webkit-unassigned] [Bug 44256] [EFL] Private Browsing feature for WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44256





--- Comment #48 from Grzegorz <g.czajkowski at samsung.com>  2011-06-13 00:28:06 PST ---
(In reply to comment #47)
> (From update of attachment 84026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84026&action=review
> 
> > Source/WebKit/efl/ewk/ewk_settings.cpp:330
> > +Eina_Bool ewk_settings_cache_disable_set(Eina_Bool set)
> 
> ewk_settings.cpp already has ewk_settings_cache_enable_set(). You need to remove this function from this patch.

Yes, I've already moved this function because it can be used in general mode too.

> 
> ewk_settings.cpp.
> 355 void ewk_settings_cache_enable_set(Eina_Bool set)
> 356 {
> 357     WebCore::MemoryCache* cache = WebCore::memoryCache();
> 358     set = !set;
> 359     if (cache->disabled() != set)
> 360         cache->setDisabled(set);
> 361 }
> 362 
> 
> Grzegorz,
> Are you preparing new patch for this bug ?

I don't think that patch is needed since WebKit's private browsing has been extended a lot.
One method that is worth to submit is:
ewk_cookie_jar_fake_set which replaces/restores default cookie jar of Soup session.
Do we need this? What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.