[Webkit-unassigned] [Bug 62518] If an Event Listener is a Function, It Should be Called and Not Checked for handleEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62518





--- Comment #6 from Dominic Cooney <dominicc at chromium.org>  2011-06-13 00:02:51 PST ---
(From update of attachment 96926)
View in context: https://bugs.webkit.org/attachment.cgi?id=96926&action=review

Again, I am not a reviewer and you will need to find a review for this. However here are some personal opinions about your patch.

> Source/WebCore/ChangeLog:5
> +        If an Event Listener is a Function, It Should be Called and Not Checked for handleEvent

Don't use title case here.

> Source/WebCore/ChangeLog:8
> +        If an event listener added via addEventListener() is a function, that 

You can probably delete this since it doesn't add much that isn't in line 5.

> LayoutTests/ChangeLog:12
> +        * dom/html/level3: Added.

I believe the tests under dom/html/level* are the W3C's published test suites. So you probably don't want to put this here. What about something under fast/events?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.