[Webkit-unassigned] [Bug 62518] If an Event Listener is a Function, It Should be Called and Not Checked for handleEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62518


Rob Brackett <rob at robbrackett.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96892|0                           |1
        is obsolete|                            |
  Attachment #96893|0                           |1
        is obsolete|                            |




--- Comment #4 from Rob Brackett <rob at robbrackett.com>  2011-06-12 23:27:34 PST ---
Created an attachment (id=96923)
 --> (https://bugs.webkit.org/attachment.cgi?id=96923&action=review)
[PATCH] Improved Fix for this Issue

Adding an improved patch.

I've switched to using the two-argument getCallData() helper in the change. The previous style seemed to be safe (it looks like all objects implement getCallData and jsFunction is guaranteed to be an object), but this certainly seems more foolproof.

For the layout test, I've removed a lot of the descriptive text that is specific to this bug but not necessarily to the test itself. I've also pulled all the setup and helpers out into separate files. Hopefully between these two, that should make the test more succinct and understandable.

The layout test doesn't behave exactly the same as the other DOM tests; I don't know what the right conventions are here since the "framework" appears to differ drastically across the various layout tests. Additionally, I was unsure whether I should use the selfhtml.js since that seems to be part of the official W3C tests, which this test is not. (As a side note, is this the right place for this test?)

I've also added a changelog. I haven't ever submitted a patch to WebKit before, so hopefully the formatting is correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.